wwj6591812 commented on code in PR #4340:
URL: https://github.com/apache/paimon/pull/4340#discussion_r1803999637
##########
paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalog.java:
##########
@@ -466,6 +469,113 @@ public TableSchema getDataTableSchema(Identifier
identifier) throws TableNotExis
.orElseThrow(() -> new TableNotExistException(identifier));
}
+ @Override
+ public View getView(Identifier identifier) throws ViewNotExistException {
+ Table table;
+ try {
+ table =
+ clients.run(
+ client ->
+ client.getTable(
+ identifier.getDatabaseName(),
+ identifier.getTableName()));
+ } catch (NoSuchObjectException e) {
+ throw new ViewNotExistException(identifier);
+ } catch (TException e) {
+ throw new RuntimeException(e);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ throw new RuntimeException(e);
+ }
+
+ boolean isView = TableType.valueOf(table.getTableType()) ==
TableType.VIRTUAL_VIEW;
Review Comment:
if (TableType.valueOf(table.getTableType()) != TableType.VIRTUAL_VIEW) {
throw new ViewNotExistException(identifier);
}
##########
paimon-core/src/main/java/org/apache/paimon/view/ViewImpl.java:
##########
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.view;
+
+import org.apache.paimon.catalog.Identifier;
+import org.apache.paimon.types.RowType;
+
+import javax.annotation.Nullable;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Optional;
+
+/** Implementation of {@link View}. */
+public class ViewImpl implements View {
+
+ private final Identifier identifier;
+ private final RowType rowType;
+ private final String query;
+ @Nullable private final String comment;
+ private final Map<String, String> options;
+
+ public ViewImpl(
+ Identifier identifier,
+ RowType rowType,
+ String query,
+ @Nullable String comment,
+ Map<String, String> options) {
+ this.identifier = identifier;
+ this.rowType = rowType;
+ this.query = query;
+ this.comment = comment;
+ this.options = options;
+ }
+
+ @Override
+ public String name() {
+ return identifier.getObjectName();
+ }
+
+ @Override
+ public String fullName() {
+ return identifier.getFullName();
+ }
+
+ @Override
+ public RowType rowType() {
+ return rowType;
+ }
+
+ @Override
+ public String query() {
+ return query;
+ }
+
+ @Override
+ public Optional<String> comment() {
+ return Optional.ofNullable(comment);
+ }
+
+ @Override
+ public Map<String, String> options() {
+ return options;
+ }
+
+ @Override
+ public View copy(Map<String, String> dynamicOptions) {
+ Map<String, String> newOptions = new HashMap<>(options);
+ newOptions.putAll(dynamicOptions);
+ return new ViewImpl(identifier, rowType, query, comment, newOptions);
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) return true;
Review Comment:
NeedBraces: 'if' construct must use '{}'s.
##########
paimon-core/src/main/java/org/apache/paimon/view/ViewImpl.java:
##########
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.view;
+
+import org.apache.paimon.catalog.Identifier;
+import org.apache.paimon.types.RowType;
+
+import javax.annotation.Nullable;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Optional;
+
+/** Implementation of {@link View}. */
+public class ViewImpl implements View {
+
+ private final Identifier identifier;
+ private final RowType rowType;
+ private final String query;
+ @Nullable private final String comment;
+ private final Map<String, String> options;
+
+ public ViewImpl(
+ Identifier identifier,
+ RowType rowType,
+ String query,
+ @Nullable String comment,
+ Map<String, String> options) {
+ this.identifier = identifier;
+ this.rowType = rowType;
+ this.query = query;
+ this.comment = comment;
+ this.options = options;
+ }
+
+ @Override
+ public String name() {
+ return identifier.getObjectName();
+ }
+
+ @Override
+ public String fullName() {
+ return identifier.getFullName();
+ }
+
+ @Override
+ public RowType rowType() {
+ return rowType;
+ }
+
+ @Override
+ public String query() {
+ return query;
+ }
+
+ @Override
+ public Optional<String> comment() {
+ return Optional.ofNullable(comment);
+ }
+
+ @Override
+ public Map<String, String> options() {
+ return options;
+ }
+
+ @Override
+ public View copy(Map<String, String> dynamicOptions) {
+ Map<String, String> newOptions = new HashMap<>(options);
+ newOptions.putAll(dynamicOptions);
+ return new ViewImpl(identifier, rowType, query, comment, newOptions);
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) return true;
+ if (o == null || getClass() != o.getClass()) return false;
Review Comment:
NeedBraces: 'if' construct must use '{}'s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
