xuzifu666 commented on code in PR #4385:
URL: https://github.com/apache/paimon/pull/4385#discussion_r1821803287
##########
paimon-core/src/main/java/org/apache/paimon/sort/BinaryExternalSortBuffer.java:
##########
@@ -120,7 +120,7 @@ public static BinaryExternalSortBuffer create(
int maxNumFileHandles,
CompressOptions compression,
MemorySize maxDiskSize) {
- RecordComparator comparator =
newRecordComparator(rowType.getFieldTypes(), keyFields);
+ RecordComparator comparator =
newRecordComparator(rowType.getFieldTypes(), keyFields, true);
Review Comment:
Yes, here should keep the same with options. Had change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
