zhuzhurk commented on code in PR #4395:
URL: https://github.com/apache/paimon/pull/4395#discussion_r1822423389
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/source/StaticFileStoreSplitEnumerator.java:
##########
@@ -118,6 +120,12 @@ public Snapshot snapshot() {
return snapshot;
}
+ @Override
+ public void handleSourceEvent(int subtaskId, int attemptNumber,
SourceEvent sourceEvent) {
+ // Only recognize events that don't care attemptNumber
+ handleSourceEvent(subtaskId, sourceEvent);
+ }
+
@Override
public void handleSourceEvent(int subtaskId, SourceEvent sourceEvent) {
if (sourceEvent instanceof ReaderConsumeProgressEvent) {
Review Comment:
Maybe add a comment to note that when to support a new kind of event, one
needs to pay attention that whether the event can be sent multiple times from
different attempts of one subtask. See the description of
`SupportsHandleExecutionAttemptSourceEvent` for more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
