askwang commented on code in PR #4346:
URL: https://github.com/apache/paimon/pull/4346#discussion_r1822757604


##########
paimon-core/src/main/java/org/apache/paimon/table/AbstractFileStoreTable.java:
##########
@@ -576,6 +576,19 @@ public void renameTag(String tagName, String 
targetTagName) {
         tagManager().renameTag(tagName, targetTagName);
     }
 
+    @Override
+    public void replaceTag(String tagName, @Nullable Duration timeRetained) {
+        Snapshot latestSnapshot = snapshotManager().latestSnapshot();
+        SnapshotNotExistException.checkNotNull(
+                latestSnapshot, "Cannot replace tag because latest snapshot 
doesn't exist.");
+        tagManager().replaceTag(latestSnapshot, tagName, timeRetained);
+    }
+
+    @Override
+    public void replaceTag(String tagName, long fromSnapshotId, @Nullable 
Duration timeRetained) {

Review Comment:
   updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to