JingsongLi commented on code in PR #4416:
URL: https://github.com/apache/paimon/pull/4416#discussion_r1823801147
##########
paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalog.java:
##########
@@ -721,6 +722,11 @@ private Table createHiveTable(Identifier identifier,
TableSchema tableSchema, Pa
tblProperties.putAll(convertToPropertiesTableKey(tableSchema));
} else {
tblProperties =
convertToPropertiesPrefixKey(tableSchema.options(), HIVE_PREFIX);
+ if
(tableSchema.options().containsKey(PARTITION_EXPIRATION_TIME.key())) {
Review Comment:
Add some comment, what is used for hms server.
##########
paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalog.java:
##########
@@ -721,6 +722,11 @@ private Table createHiveTable(Identifier identifier,
TableSchema tableSchema, Pa
tblProperties.putAll(convertToPropertiesTableKey(tableSchema));
} else {
tblProperties =
convertToPropertiesPrefixKey(tableSchema.options(), HIVE_PREFIX);
+ if
(tableSchema.options().containsKey(PARTITION_EXPIRATION_TIME.key())) {
Review Comment:
Add some comment, how is used for hms server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
