JingsongLi commented on code in PR #3843:
URL: https://github.com/apache/paimon/pull/3843#discussion_r1849751340
##########
paimon-spark/paimon-spark-common/src/main/java/org/apache/paimon/spark/SparkCatalog.java:
##########
@@ -411,6 +411,12 @@ private Schema toInitialSchema(
}
normalizedProperties.remove(PRIMARY_KEY_IDENTIFIER);
normalizedProperties.remove(TableCatalog.PROP_COMMENT);
+ if (normalizedProperties.containsKey(TableCatalog.PROP_LOCATION)) {
+ String path =
normalizedProperties.remove(TableCatalog.PROP_LOCATION);
+ normalizedProperties.put(CoreOptions.PATH.key(), path);
+ // For v2 table, as long as it has specified the location, treat
it as external
+ normalizedProperties.put(Catalog.EXTERNAL_PROP, "true");
Review Comment:
We don't need this option, hive catalog can know if it is a external table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
