wwj6591812 commented on code in PR #4558:
URL: https://github.com/apache/paimon/pull/4558#discussion_r1851212512
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/lookup/LookupDataTableScan.java:
##########
@@ -58,6 +62,16 @@ public LookupDataTableScan(
this.lookupScanMode = lookupScanMode;
}
+ @Override
+ @Nullable
+ protected SnapshotReader.Plan tryGetOverwirtePlan(Snapshot snapshot) {
Review Comment:
tryGetOverwritePlan
##########
paimon-core/src/main/java/org/apache/paimon/table/source/DataTableStreamScan.java:
##########
@@ -228,6 +228,18 @@ private boolean shouldDelaySnapshot(long snapshotId) {
return false;
}
+ @Nullable
+ protected SnapshotReader.Plan tryGetOverwirtePlan(Snapshot snapshot) {
+ if (supportStreamingReadOverwrite) {
+ LOG.debug("Find overwrite snapshot id {}.", nextSnapshotId);
Review Comment:
if (LOG.isDebugEnabled())
##########
paimon-core/src/main/java/org/apache/paimon/table/source/DataTableStreamScan.java:
##########
@@ -228,6 +228,18 @@ private boolean shouldDelaySnapshot(long snapshotId) {
return false;
}
+ @Nullable
+ protected SnapshotReader.Plan tryGetOverwirtePlan(Snapshot snapshot) {
Review Comment:
tryGetOverwritePlan
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/lookup/FileStoreLookupFunction.java:
##########
@@ -249,7 +250,7 @@ public Collection<RowData> lookup(RowData keyRow) {
rows.add(new FlinkRowData(matchedRow));
}
return rows;
- } catch (OutOfRangeException e) {
+ } catch (OutOfRangeException | DimScanOverwriteException e) {
Review Comment:
Why catch DimScanOverwriteException then reopen can solve this problem.?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
