JingsongLi commented on code in PR #4786:
URL: https://github.com/apache/paimon/pull/4786#discussion_r1899284877
##########
paimon-core/src/main/java/org/apache/paimon/rest/RESTCatalog.java:
##########
@@ -360,17 +376,45 @@ public void dropTable(Identifier identifier, boolean
ignoreIfNotExists)
@Override
public void createPartition(Identifier identifier, Map<String, String>
partitionSpec)
throws TableNotExistException {
- throw new UnsupportedOperationException();
+ try {
+ CreatePartitionRequest request = new
CreatePartitionRequest(identifier, partitionSpec);
+ client.post(
+ resourcePaths.partitions(
+ identifier.getDatabaseName(),
identifier.getTableName()),
+ request,
+ SuccessResponse.class,
+ headers());
+ } catch (NoSuchResourceException e) {
+ throw new TableNotExistException(identifier);
+ } catch (ForbiddenException e) {
+ throw new TableNoPermissionException(identifier, e);
+ }
}
@Override
public void dropPartition(Identifier identifier, Map<String, String>
partitions)
- throws TableNotExistException, PartitionNotExistException {}
+ throws TableNotExistException, PartitionNotExistException {
+ checkNotSystemTable(identifier, "dropPartition");
+ dropPartitionMetadata(identifier, partitions);
+ Table table = getTable(identifier);
+ if (table != null) {
Review Comment:
it is null? I think maybe getTable will throw TableNotExistsException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
