Tan-JiaLiang commented on code in PR #4812:
URL: https://github.com/apache/paimon/pull/4812#discussion_r1903688832
##########
paimon-format/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java:
##########
@@ -228,17 +230,20 @@ private static ParquetMetadata readFooter(
private ColumnChunkPageReadStore currentRowGroup = null;
private DictionaryPageReader nextDictionaryReader = null;
- private InternalFileDecryptor fileDecryptor = null;
- private FileIndexResult fileIndexResult;
+ private InternalFileDecryptor fileDecryptor;
public ParquetFileReader(
- InputFile file, ParquetReadOptions options, FileIndexResult
fileIndexResult)
+ InputFile file,
+ ParquetReadOptions options,
+ @Nullable RoaringBitmap32 selection,
+ @Nullable RoaringBitmap32 deletion)
Review Comment:
If only the deletion vector, do you want to push it down? According to the
current benchmark, it does not work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
