JingsongLi commented on code in PR #4892:
URL: https://github.com/apache/paimon/pull/4892#discussion_r1912779559
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/memory/MemorySegmentAllocator.java:
##########
@@ -62,9 +62,8 @@ public MemorySegment allocate() {
checkNotNull(segment, "Allocate null segment from memory manager
for paimon.");
checkArgument(segment.isOffHeap(), "Segment is not off heap from
memory manager.");
allocatedSegments.add(segment);
- // TODO Use getOffHeapBuffer in MemorySegment after
- // https://issues.apache.org/jira/browse/FLINK-32213
- return MemorySegment.wrapOffHeapMemory((ByteBuffer)
offHeapBufferField.get(segment));
+ ByteBuffer offHeapBuffer = segment.getOffHeapBuffer();
Review Comment:
Flink 1.15 and 1.16 and 1.17 will be break by this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
