neuyilan commented on code in PR #4891:
URL: https://github.com/apache/paimon/pull/4891#discussion_r1921699152
##########
paimon-core/src/main/java/org/apache/paimon/table/FileStoreTableFactory.java:
##########
@@ -38,12 +37,8 @@
public class FileStoreTableFactory {
public static FileStoreTable create(CatalogContext context) {
- FileIO fileIO;
- try {
- fileIO = FileIO.get(CoreOptions.path(context.options()), context);
- } catch (IOException e) {
- throw new UncheckedIOException(e);
- }
+ FileIO fileIO = new ResolvingFileIO();
Review Comment:
I started to think the same way. In this case, simply adding the table
attribute `data-file.external-paths` by the user cannot achieve the purpose of
writing data to the external path, and users also need to modify the attributes
of the catalog. For example, `enable_external_path`. Do you think this usage is
okay?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
