JingsongLi commented on code in PR #4844:
URL: https://github.com/apache/paimon/pull/4844#discussion_r1921714459
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/clone/CloneFileInfo.java:
##########
@@ -18,29 +18,35 @@
package org.apache.paimon.flink.clone;
+import javax.annotation.Nullable;
+
/** The information of copy file. */
public class CloneFileInfo {
-
- private final String sourceFilePath;
- private final String filePathExcludeTableRoot;
+ @Nullable private final String sourceFilePath;
+ @Nullable private final String filePathExcludeTableRoot;
private final String sourceIdentifier;
private final String targetIdentifier;
+ private final long snapshotId;
Review Comment:
I think we don't need to worry about deleting files in the manifest anymore.
We just need to see which data files we need. Although we may copy extra files,
it won't cause any problems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
