JingsongLi commented on code in PR #4982:
URL: https://github.com/apache/paimon/pull/4982#discussion_r1926679736
##########
paimon-common/src/main/java/org/apache/paimon/data/columnar/heap/HeapRowVector.java:
##########
@@ -18,47 +18,52 @@
package org.apache.paimon.data.columnar.heap;
+import org.apache.paimon.data.columnar.ColumnVector;
import org.apache.paimon.data.columnar.ColumnarRow;
import org.apache.paimon.data.columnar.RowColumnVector;
import org.apache.paimon.data.columnar.VectorizedColumnBatch;
import org.apache.paimon.data.columnar.writable.WritableColumnVector;
/** This class represents a nullable heap row column vector. */
-public class HeapRowVector extends AbstractHeapVector
+public class HeapRowVector extends AbstractStructVector
implements WritableColumnVector, RowColumnVector {
- private WritableColumnVector[] fields;
+ private VectorizedColumnBatch vectorizedColumnBatch;
- public HeapRowVector(int len, WritableColumnVector... fields) {
- super(len);
- this.fields = fields;
- }
-
- public WritableColumnVector[] getFields() {
- return fields;
+ public HeapRowVector(int len, ColumnVector... fields) {
+ super(len, fields);
+ vectorizedColumnBatch = new VectorizedColumnBatch(children);
}
@Override
public ColumnarRow getRow(int i) {
- ColumnarRow columnarRow = new ColumnarRow(new
VectorizedColumnBatch(fields));
+ ColumnarRow columnarRow = new ColumnarRow(vectorizedColumnBatch);
columnarRow.setRowId(i);
return columnarRow;
}
@Override
public VectorizedColumnBatch getBatch() {
- return new VectorizedColumnBatch(fields);
+ return new VectorizedColumnBatch(children);
Review Comment:
use vectorizedColumnBatch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
