JingsongLi commented on code in PR #5095:
URL: https://github.com/apache/paimon/pull/5095#discussion_r1961529274
##########
paimon-core/src/main/java/org/apache/paimon/operation/KeyValueFileStoreScan.java:
##########
@@ -99,6 +100,11 @@ public KeyValueFileStoreScan(
this.mergeEngine = mergeEngine;
this.changelogProducer = changelogProducer;
this.fileIndexReadEnabled = fileIndexReadEnabled;
+ this.onlyReadRealBuckets = onlyReadRealBuckets;
+
+ if (onlyReadRealBuckets) {
+ super.withBucketFilter(bucket -> bucket >= 0);
Review Comment:
this will overwrite old bucket filter, or be overwrited new bucket filter,
maybe we should add a method to skip negative buckets...
##########
paimon-core/src/main/java/org/apache/paimon/operation/KeyValueFileStoreScan.java:
##########
@@ -99,6 +100,11 @@ public KeyValueFileStoreScan(
this.mergeEngine = mergeEngine;
this.changelogProducer = changelogProducer;
this.fileIndexReadEnabled = fileIndexReadEnabled;
+ this.onlyReadRealBuckets = onlyReadRealBuckets;
+
+ if (onlyReadRealBuckets) {
+ super.withBucketFilter(bucket -> bucket >= 0);
Review Comment:
this will overwrite old bucket filter, or be overwrited new bucket filter,
maybe we should add a method to skip negative buckets... Please add cases for
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
