JingsongLi commented on code in PR #5101:
URL: https://github.com/apache/paimon/pull/5101#discussion_r1962824891
##########
paimon-common/src/main/java/org/apache/paimon/utils/InternalRowUtils.java:
##########
@@ -48,13 +48,74 @@
import java.math.BigDecimal;
import java.math.RoundingMode;
import java.util.ArrayList;
+import java.util.Arrays;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
/** Utils for {@link InternalRow} structures. */
public class InternalRowUtils {
+ public static boolean equals(Object data1, Object data2, DataType
dataType) {
+ if ((data1 == null) != (data2 == null)) {
+ return false;
+ }
+ if (data1 != null) {
+ if (data1 instanceof InternalRow) {
Review Comment:
But they are not safe, if there is a row inside array or map, it is not safe
too.
So it is better to add implementation for array and map too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
