Zouxxyy commented on PR #5140:
URL: https://github.com/apache/paimon/pull/5140#issuecomment-2680567388
Thanks, accept
---Original---
From: "Jingsong ***@***.***>
Date: Mon, Feb 24, 2025 22:17 PM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [apache/paimon] [spark] support spark procedure for removing
table exists in metastor… (PR #5140)
@JingsongLi requested changes on this pull request.
In
paimon-spark/paimon-spark-common/src/main/java/org/apache/paimon/spark/procedure/RemoveNonExistingTableProcedure.java:
> + tableName); +
org.apache.paimon.catalog.Identifier identifier = +
org.apache.paimon.catalog.Identifier.fromString( +
toIdentifier(args.getString(0), PARAMETERS[0].name()).toString()); +
LOG.info("identifier in RemoveNonExistingTableProcedure is {}.", identifier); +
+ Catalog paimonCatalog = ((WithPaimonCatalog)
tableCatalog()).paimonCatalog(); + Catalog wrappedCatalog; + if
(paimonCatalog instanceof CachingCatalog) { + wrappedCatalog =
((CachingCatalog) paimonCatalog).wrapped(); + } else { +
wrappedCatalog = paimonCatalog; + } + if (!(wrappedCatalog
instanceof HiveCatalog)) { + throw new IllegalArgumentException( +
"Only support Hive Catalog in
RemoveNonExistingTableProcedure");
Actually, this procedure is just for HiveCatalog, it is
remove_non_existing_table_for_hive_catalog.
If this is not a commonly used procedure, I suggest not pushing it forward.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
