plusplusjiajia commented on code in PR #5253:
URL: https://github.com/apache/paimon/pull/5253#discussion_r1988456116
##########
paimon-core/src/main/java/org/apache/paimon/rest/RESTTokenFileIO.java:
##########
@@ -153,7 +153,8 @@ private FileIO fileIO() throws IOException {
CatalogContext context = catalogLoader.context();
Options options = context.options();
- options = new Options(RESTUtil.merge(options.toMap(),
token.token()));
+ // the original options are not overwritten
+ options = new Options(RESTUtil.merge(token.token(),
options.toMap()));
Review Comment:
> Is it possible to provide a separate method to get options from options
and token, and add a test to protect this logic?
good idea! done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
