JingsongLi commented on code in PR #5270:
URL: https://github.com/apache/paimon/pull/5270#discussion_r1992609072
##########
paimon-core/src/main/java/org/apache/paimon/table/source/DataSplit.java:
##########
@@ -141,6 +144,44 @@ public long mergedRowCount() {
return partialMergedRowCount();
}
+ public Object minValue(DataField dataField) {
+ Object minValue = null;
+ for (int i = 0; i < dataFiles().size(); i++) {
+ DataFileMeta dataFile = dataFiles.get(i);
+ Object other =
+ InternalRowUtils.get(
+ dataFile.valueStats().minValues(), dataField.id(),
dataField.type());
Review Comment:
You should get valueStatsCol here, the index should be re-compute here by
valueStatsCol.
##########
paimon-core/src/main/java/org/apache/paimon/table/source/DataSplit.java:
##########
@@ -141,6 +144,44 @@ public long mergedRowCount() {
return partialMergedRowCount();
}
+ public Object minValue(DataField dataField) {
+ Object minValue = null;
+ for (int i = 0; i < dataFiles().size(); i++) {
+ DataFileMeta dataFile = dataFiles.get(i);
+ Object other =
+ InternalRowUtils.get(
+ dataFile.valueStats().minValues(), dataField.id(),
dataField.type());
Review Comment:
You should get valueStatsCol here, the index should be re-compute here by
valueStatsCol.
Please add test too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
