askwang commented on code in PR #5297:
URL: https://github.com/apache/paimon/pull/5297#discussion_r2002632584


##########
paimon-core/src/main/java/org/apache/paimon/utils/ManifestReadThreadPool.java:
##########
@@ -36,7 +36,7 @@ public class ManifestReadThreadPool {
             createCachedThreadPool(Runtime.getRuntime().availableProcessors(), 
THREAD_NAME);
 
     public static synchronized ThreadPoolExecutor getExecutorService(@Nullable 
Integer threadNum) {
-        if (threadNum == null || threadNum <= 
executorService.getMaximumPoolSize()) {
+        if (threadNum == null || threadNum >= 
executorService.getMaximumPoolSize()) {

Review Comment:
   We find there are 64 manifest thread when doing full manifest merge, it 
takes up a lot of memory, we want to relieve it by reducing the thream num.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to