JingsongLi commented on code in PR #5316:
URL: https://github.com/apache/paimon/pull/5316#discussion_r2004998226


##########
paimon-core/src/main/java/org/apache/paimon/catalog/Catalog.java:
##########
@@ -531,6 +532,26 @@ boolean commitSnapshot(
     Optional<TableSnapshot> loadSnapshot(Identifier identifier)
             throws Catalog.TableNotExistException;
 
+    /**
+     * rollback table by the given {@link Identifier} and 
tableRollbackToInstant.
+     *
+     * @param identifier path of the table
+     * @param tableRollbackToInstant rollback instance like snapshotId or 
tagName
+     * @return whether success
+     * @throws Catalog.TableNotExistException if the target does not exist
+     */
+    boolean rollbackTo(Identifier identifier, TableRollbackToInstant 
tableRollbackToInstant)

Review Comment:
   It is good to introduce `org.apache.paimon.table.Instant` class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to