Sxnan commented on code in PR #5408: URL: https://github.com/apache/paimon/pull/5408#discussion_r2030384317
########## .github/workflows/e2e-tests-flink-2.x-jdk11.yml: ########## @@ -0,0 +1,70 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################ + +name: End to End Tests Flink 2.x on JDK 11 + +on: + issue_comment: Review Comment: Should the test be triggered on push and pull requests similar to the Flink 1.x JDK 8 e2e test? ########## paimon-e2e-tests/pom.xml: ########## @@ -77,6 +77,14 @@ under the License. <type>test-jar</type> </dependency> + <dependency> Review Comment: Can we remove this? I think the module already includes `paimon-flink-common`, which includes `paimon-flinkx-common` accordingly. Same for the other modules like `paimon-flink-x.xx`, `paimon-flink-action`, etc. ########## paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/source/operator/OperatorSourceTest.java: ########## @@ -299,6 +300,9 @@ public void emitLatencyMarker(LatencyMarker latencyMarker) {} @Override public void emitRecordAttributes(RecordAttributes recordAttributes) {} + + // @Override is skipped for compatibility with Flink 1.x. Review Comment: How is this handle for Spark3 and Spark4? ########## .github/workflows/utitcase-flink-2.x-jdk11.yml: ########## @@ -0,0 +1,62 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################ + +name: UTCase and ITCase Flink 2.x on JDK 11 + +on: + issue_comment: Review Comment: Same comment as the e2e test triggering -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
