liyubin117 commented on code in PR #5408:
URL: https://github.com/apache/paimon/pull/5408#discussion_r2032746080
##########
paimon-e2e-tests/src/test/java/org/apache/paimon/tests/cdc/MySql57E2eTest.java:
##########
@@ -20,12 +20,21 @@
import org.apache.paimon.flink.action.cdc.mysql.MySqlVersion;
+import org.junit.jupiter.api.condition.EnabledIf;
+
/**
* E2e tests for {@link
org.apache.paimon.flink.action.cdc.mysql.MySqlSyncTableAction} with MySQL
* 5.7.
*/
+@EnabledIf("runTest")
public class MySql57E2eTest extends MySqlCdcE2eTestBase {
+ private static boolean runTest() {
+ // TODO: modify the following condition after paimon-flink-cdc
supports flink 2.0
+ String flinkVersion = System.getProperty("test.flink.main.version");
+ return flinkVersion.compareTo("2.0") < 0;
+ }
+
Review Comment:
Could we move the function to the super class, and sub class override the
function when needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
