wwj6591812 commented on code in PR #5445:
URL: https://github.com/apache/paimon/pull/5445#discussion_r2043248662
##########
paimon-common/src/main/java/org/apache/paimon/CoreOptions.java:
##########
@@ -127,6 +127,18 @@ public class CoreOptions implements Serializable {
+ "if there is no primary
key, the full row will be used.")
.build());
+ @Immutable
+ public static final ConfigOption<HashType> BUCKET_HASH_TYPE =
+ key("bucket.hash-type")
+ .enumType(HashType.class)
+ .defaultValue(HashType.PAIMON)
+ .withDescription("The hash mode for paimon bucket");
+
+ /** Paimon bucket hash type. */
+ public enum HashType {
Review Comment:
BucketHashType?
##########
paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/HashTypeITCase.java:
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.flink;
+
+import org.apache.paimon.CoreOptions.HashType;
+
+import org.apache.flink.types.Row;
+import org.assertj.core.api.Assertions;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.EnumSource;
+
+import java.util.List;
+
+/** Hash type ITCase. */
+public class HashTypeITCase extends CatalogITCaseBase {
+
+ @ParameterizedTest
+ @EnumSource(HashType.class)
+ public void testInsertAndSelect(HashType hashType) throws Exception {
Review Comment:
remove `throws Exception`
##########
paimon-core/src/main/java/org/apache/paimon/hash/HashFunction.java:
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.hash;
+
+import org.apache.paimon.CoreOptions;
+import org.apache.paimon.data.BinaryRow;
+import org.apache.paimon.types.RowType;
+
+/** Bucket key hash function. */
+public interface HashFunction {
Review Comment:
In https://github.com/apache/paimon/issues/5444, the Motivation is `make
bucket hash function pluggable`.
But in this PR, I can't find where the logic of load my custom class that
implement HashFunction.
##########
paimon-flink/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/sink/cdc/CdcRecordKeyAndBucketExtractor.java:
##########
@@ -43,6 +44,7 @@ public class CdcRecordKeyAndBucketExtractor implements
KeyAndBucketExtractor<Cdc
private final Projection bucketKeyProjection;
private final List<DataField> trimmedPKFields;
private final Projection trimmedPKProjection;
+ private final HashFunction hashFunction;
Review Comment:
bucketHashFunction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
