JingsongLi commented on code in PR #5725:
URL: https://github.com/apache/paimon/pull/5725#discussion_r2137496635
##########
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java:
##########
@@ -1252,10 +1257,47 @@ private List<SimpleFileEntry>
readAllEntriesFromChangedPartitions(
private void noConflictsOrFail(
String baseCommitUser,
List<SimpleFileEntry> baseEntries,
- List<SimpleFileEntry> changes) {
+ List<SimpleFileEntry> changes,
+ Snapshot.CommitKind commitKind) {
List<SimpleFileEntry> allEntries = new ArrayList<>(baseEntries);
allEntries.addAll(changes);
+ if (commitKind != Snapshot.CommitKind.OVERWRITE) {
Review Comment:
Why we need to exclude overwrite? Overwrite has no old files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
