tsreaper commented on code in PR #5776:
URL: https://github.com/apache/paimon/pull/5776#discussion_r2156792832
##########
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java:
##########
@@ -1110,54 +1088,57 @@ CommitResult tryCommitOnce(
e);
}
- if (commitSnapshotImpl(newSnapshot, deltaStatistics)) {
- LOG.info(
- "Successfully commit snapshot {} to table {} by user {} "
- + "with identifier {} and kind {}.",
+ boolean success;
+ try {
+ success = commitSnapshotImpl(newSnapshot, deltaStatistics);
+ } catch (Exception e) {
+ // commit exception, not sure about the situation and should not
clean up the files
+ LOG.warn("Retry commit for exception.", e);
+ return new RetryResult(latestSnapshot, baseDataFiles, e);
Review Comment:
#5571 should also check type of snapshots must be the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
