WenDing-Y commented on PR #5906:
URL: https://github.com/apache/paimon/pull/5906#issuecomment-3095451764

   > Hi @WenDing-Y
   > 
   > Deletion-Vectors can not be changed for the table with data. Only can be 
changed after full-compaction.
   > 
   > And your fix has problem. Let dv table has bad query performance.
   
   
   
   > Hi @WenDing-Y
   > 
   > Deletion-Vectors can not be changed for the table with data. Only can be 
changed after full-compaction.
   > 
   > And your fix has problem. Let dv table has bad query performance.
   
   Deletion vectors do not modify the data itself, but they do change the way 
data is read.
   where deletionVectorsEnabled is true,if same ID are present in different 
Parquet files,The result may be duplicated.
   ```
     if (rawConvertible
                  
                   && (deletionVectorsEnabled || mergeEngine == FIRST_ROW || 
oneLevel)) {
               Function<DataFileMeta, Long> weightFunc =
                       file -> Math.max(file.fileSize(), openFileCost);
               return BinPacking.packForOrdered(files, weightFunc, 
targetSplitSize).stream()
                       .map(SplitGroup::rawConvertibleGroup)
                       .collect(Collectors.toList());
           }
   
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to