leaves12138 commented on code in PR #5935:
URL: https://github.com/apache/paimon/pull/5935#discussion_r2235272548


##########
paimon-core/src/main/java/org/apache/paimon/utils/FormatReaderMapping.java:
##########
@@ -165,6 +175,16 @@ public FormatReaderMapping build(
 
             // extract the whole data fields in logic.
             List<DataField> allDataFields = fieldsExtractor.apply(dataSchema);
+            if 
(CoreOptions.fromMap(dataSchema.options()).rowTrackingEnabled()) {
+                allDataFields.add(SpecialFields.ROW_ID);
+                allDataFields.add(SpecialFields.SEQUENCE_NUMBER.copy(true));
+            }
+            List<DataField> metaDataFields =
+                    Arrays.asList(SpecialFields.ROW_ID, 
SpecialFields.SEQUENCE_NUMBER);
+            int[] metaMappings = createIndexMapping(allDataFields, 
metaDataFields);
+
+            Map<String, Integer> meta = findMeta(readTableFields);

Review Comment:
   OK



##########
paimon-core/src/main/java/org/apache/paimon/utils/FormatReaderMapping.java:
##########
@@ -67,13 +71,15 @@ public FormatReaderMapping(
             @Nullable Pair<int[], RowType> partitionPair,
             FormatReaderFactory readerFactory,
             TableSchema dataSchema,
-            List<Predicate> dataFilters) {
+            List<Predicate> dataFilters,
+            Map<String, Integer> meta) {

Review Comment:
   OK



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to