JingsongLi commented on code in PR #5978:
URL: https://github.com/apache/paimon/pull/5978#discussion_r2239541285
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/listener/PartitionMarkDoneTrigger.java:
##########
@@ -167,7 +176,10 @@ LocalDateTime extractDateTime(String partition) {
try {
return timeExtractor.extract(extractPartitionSpecFromPath(new
Path(partition)));
} catch (DateTimeParseException e) {
- throw new RuntimeException("Can't extract datetime from partition
" + partition, e);
+ LOG.warn(
+ "Can't extract datetime from partition {}, please check
configuration items 'partition.timestamp-formatter' and
'partition.timestamp-pattern'.",
+ partition);
+ return LocalDateTime.MIN;
Review Comment:
Can we just return Optional.empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
