LsomeYeah commented on code in PR #6024:
URL: https://github.com/apache/paimon/pull/6024#discussion_r2256347900
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/compact/AppendTableCompactor.java:
##########
@@ -199,4 +207,34 @@ public List<Committable> prepareCommit(boolean
waitCompaction, long checkpointId
public Iterable<Future<CommitMessage>> result() {
return result;
}
+
+ private void replace(FileStoreTable newTable) throws Exception {
+ if (commitUser == null) {
+ return;
Review Comment:
This method is copied from
org.apache.paimon.flink.sink.StoreSinkWriteImpl#replace, I guess there may be
some historical reasons behind this, because `ListState` was used for
`getCommitUser`, and if `commitUser == null`, `write` will be null too. More
details could be see in https://github.com/apache/paimon/pull/868 and
https://github.com/apache/paimon/pull/649.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
