chenghuichen commented on code in PR #6068: URL: https://github.com/apache/paimon/pull/6068#discussion_r2271933055
########## paimon-python/pypaimon/schema/table_schema.py: ########## @@ -69,6 +69,32 @@ def __init__(self, version: int, id: int, fields: List[DataField], highest_field self.options = options or {} self.comment = comment self.time_millis = time_millis if time_millis is not None else int(time.time() * 1000) + self.trim_primary_keys() + + from typing import List + + def trim_primary_keys(self) -> List[str]: Review Comment: The existing function "get_trimmed_primary_key_fields" can be simplified with this new function -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org