JingsongLi commented on code in PR #6075:
URL: https://github.com/apache/paimon/pull/6075#discussion_r2276687429
##########
paimon-api/src/main/java/org/apache/paimon/function/FunctionImpl.java:
##########
@@ -21,35 +21,38 @@
import org.apache.paimon.catalog.Identifier;
import org.apache.paimon.types.DataField;
+import javax.annotation.Nullable;
+
import java.util.List;
import java.util.Map;
+import java.util.Objects;
import java.util.Optional;
/** Function implementation. */
public class FunctionImpl implements Function {
private final Identifier identifier;
- private final List<DataField> inputParams;
+ @Nullable private final List<DataField> inputParams;
- private final List<DataField> returnParams;
+ @Nullable private final List<DataField> returnParams;
private final boolean deterministic;
private final Map<String, FunctionDefinition> definitions;
- private final String comment;
+ @Nullable private final String comment;
- private final Map<String, String> options;
+ @Nullable private final Map<String, String> options;
Review Comment:
Can you just use empty Map?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
