Tan-JiaLiang commented on code in PR #6097:
URL: https://github.com/apache/paimon/pull/6097#discussion_r2286820262
##########
paimon-core/src/main/java/org/apache/paimon/operation/RawFileSplitRead.java:
##########
@@ -247,21 +243,6 @@ private FileRecordReader<InternalRow> createFileReader(
selection = ((BitmapIndexResult) fileIndexResult).get();
}
- RoaringBitmap32 deletion = null;
- DeletionVector deletionVector = dvFactory == null ? null :
dvFactory.get();
- if (deletionVector instanceof BitmapDeletionVector) {
- deletion = ((BitmapDeletionVector) deletionVector).get();
- }
-
- if (selection != null) {
- if (deletion != null) {
- selection = RoaringBitmap32.andNot(selection, deletion);
Review Comment:
In my opinion, it can be also for file index filtering. e.g.
row count is 5 ==> selection is [0,1,2,3,4,5], if deletion is [1,3,5]. After
selection AND NOT deletion, the result is [0,2,4], so after merge, the
selection is [0,2,4].
So, we can base the [0,2,4] position to pick the TopN and the Predicate
Filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
