JingsongLi commented on code in PR #6173: URL: https://github.com/apache/paimon/pull/6173#discussion_r2309561034
########## paimon-core/src/main/java/org/apache/paimon/utils/CompactedChangelogPathResolver.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.paimon.utils; + +import org.apache.paimon.fs.Path; + +/** + * Utility class for resolving compacted changelog file paths. + * + * <p>This class provides functionality to resolve fake compacted changelog file paths to their real + * file paths, following the same protocol as CompactedChangelogFormatReaderFactory. Review Comment: Can you also move logic codes into this class from `CompactedChangelogFormatReaderFactory`? It is better to keep protocol in one single class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
