Copilot commented on code in PR #6190: URL: https://github.com/apache/paimon/pull/6190#discussion_r2318057852
########## paimon-core/src/test/java/org/apache/paimon/table/format/FormatReadBuilderTest.java: ########## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.paimon.table.format; + +import org.apache.paimon.catalog.Identifier; +import org.apache.paimon.fs.Path; +import org.apache.paimon.fs.local.LocalFileIO; +import org.apache.paimon.predicate.Predicate; +import org.apache.paimon.predicate.PredicateBuilder; +import org.apache.paimon.table.FormatTable; +import org.apache.paimon.types.DataTypes; +import org.apache.paimon.types.RowType; +import org.apache.paimon.utils.InstantiationUtil; + +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.io.TempDir; + +import java.io.IOException; +import java.util.Arrays; +import java.util.HashMap; +import java.util.Map; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatNoException; + +/** Test for {@link FormatReadBuilder} serialization. */ +public class FormatReadBuilderTest { + + @TempDir java.nio.file.Path tempPath; + + @Test + public void testSerializeAndDeserialize() throws IOException, ClassNotFoundException { + RowType rowType = + RowType.builder() + .field("partition_key", DataTypes.STRING()) + .field("id", DataTypes.BIGINT()) + .field("data", DataTypes.STRING()) + .field("timestamp", DataTypes.TIMESTAMP()) + .build(); + + Map<String, String> options = new HashMap<>(); + options.put("file.format", "orc"); + options.put("file.compression", "zstd"); + + Path tablePath = new Path(tempPath.toUri()); + FormatTable table = + FormatTable.builder() + .fileIO(LocalFileIO.create()) + .identifier(Identifier.create("test_db", "complex_table")) + .rowType(rowType) + .partitionKeys(Arrays.asList("partition_key")) + .location(tablePath.toString()) + .format(FormatTable.Format.ORC) + .options(options) + .build(); + + FormatReadBuilder readBuilder = new FormatReadBuilder(table); + + assertThatNoException().isThrownBy(() -> InstantiationUtil.serializeObject(readBuilder)); + assertThatNoException() + .isThrownBy( + () -> + InstantiationUtil.deserializeObject( + InstantiationUtil.serializeObject(readBuilder), + getClass().getClassLoader())); + + // Add multiple filters + PredicateBuilder predicateBuilder = new PredicateBuilder(rowType); + Predicate filter1 = predicateBuilder.greaterThan(1, 1000L); // id > 1000 + Predicate filter2 = predicateBuilder.isNotNull(2); // data is not null Review Comment: Magic numbers 1 and 2 are used as field indices. Consider using named constants or the field names to make the test more maintainable: `predicateBuilder.greaterThan("id", 1000L)` and `predicateBuilder.isNotNull("data")`. ```suggestion Predicate filter1 = predicateBuilder.greaterThan("id", 1000L); // id > 1000 Predicate filter2 = predicateBuilder.isNotNull("data"); // data is not null ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
