JingsongLi commented on code in PR #6229:
URL: https://github.com/apache/paimon/pull/6229#discussion_r2335481221
##########
paimon-python/pypaimon/manifest/manifest_file_manager.py:
##########
@@ -61,11 +61,14 @@ def read(self, manifest_file_name: str, shard_filter=None)
-> List[ManifestEntry
null_counts=key_dict['_NULL_COUNTS'],
)
value_dict = dict(file_dict['_VALUE_STATS'])
+ # TODO add dropStats logic to improve performance
+
value_stats = SimpleStats(
-
min_values=BinaryRowDeserializer.from_bytes(value_dict['_MIN_VALUES'],
-
self.table.table_schema.fields),
-
max_values=BinaryRowDeserializer.from_bytes(value_dict['_MAX_VALUES'],
-
self.table.table_schema.fields),
+ min_values=BinaryRow([], []) if record['_KIND'] == 1 else
BinaryRowDeserializer.from_bytes(
Review Comment:
This column number needs to be aligned with `valueStatsCols`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
