JingsongLi commented on code in PR #6285: URL: https://github.com/apache/paimon/pull/6285#discussion_r2361879407
##########
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java:
##########
@@ -701,51 +702,53 @@ private void collectChanges(
.compactIncrement()
.changelogFiles()
.forEach(m -> compactChangelog.add(makeEntry(FileKind.ADD,
commitMessage, m)));
- commitMessage
- .indexIncrement()
- .newIndexFiles()
- .forEach(
- f -> {
- switch (f.indexType()) {
- case HASH_INDEX:
- appendHashIndexFiles.add(
- new IndexManifestEntry(
- FileKind.ADD,
-
commitMessage.partition(),
- commitMessage.bucket(),
- f));
- break;
- case DELETION_VECTORS_INDEX:
- compactDvIndexFiles.add(
- new IndexManifestEntry(
- FileKind.ADD,
-
commitMessage.partition(),
- commitMessage.bucket(),
- f));
- break;
- default:
- throw new RuntimeException(
- "Unknown index type: " +
f.indexType());
- }
- });
- commitMessage
- .indexIncrement()
- .deletedIndexFiles()
- .forEach(
- f -> {
- if
(f.indexType().equals(DELETION_VECTORS_INDEX)) {
- compactDvIndexFiles.add(
- new IndexManifestEntry(
- FileKind.DELETE,
- commitMessage.partition(),
- commitMessage.bucket(),
- f));
- } else {
- throw new RuntimeException(
- "This index type is not supported
to delete: "
- + f.indexType());
- }
- });
+
+ // todo: split them
Review Comment:
Let's finish todo
##########
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java:
##########
@@ -701,51 +702,53 @@ private void collectChanges(
.compactIncrement()
.changelogFiles()
.forEach(m -> compactChangelog.add(makeEntry(FileKind.ADD,
commitMessage, m)));
- commitMessage
- .indexIncrement()
- .newIndexFiles()
- .forEach(
- f -> {
- switch (f.indexType()) {
- case HASH_INDEX:
- appendHashIndexFiles.add(
- new IndexManifestEntry(
- FileKind.ADD,
-
commitMessage.partition(),
- commitMessage.bucket(),
- f));
- break;
- case DELETION_VECTORS_INDEX:
- compactDvIndexFiles.add(
- new IndexManifestEntry(
- FileKind.ADD,
-
commitMessage.partition(),
- commitMessage.bucket(),
- f));
- break;
- default:
- throw new RuntimeException(
- "Unknown index type: " +
f.indexType());
- }
- });
- commitMessage
- .indexIncrement()
- .deletedIndexFiles()
- .forEach(
- f -> {
- if
(f.indexType().equals(DELETION_VECTORS_INDEX)) {
- compactDvIndexFiles.add(
- new IndexManifestEntry(
- FileKind.DELETE,
- commitMessage.partition(),
- commitMessage.bucket(),
- f));
- } else {
- throw new RuntimeException(
- "This index type is not supported
to delete: "
- + f.indexType());
- }
- });
+
+ // todo: split them
+ List<IndexFileMeta> newIndexFiles =
+ new
ArrayList<>(commitMessage.newFilesIncrement().newIndexFiles());
+
newIndexFiles.addAll(commitMessage.compactIncrement().newIndexFiles());
+ newIndexFiles.forEach(
+ f -> {
+ switch (f.indexType()) {
+ case HASH_INDEX:
+ appendHashIndexFiles.add(
+ new IndexManifestEntry(
+ FileKind.ADD,
+ commitMessage.partition(),
+ commitMessage.bucket(),
+ f));
+ break;
+ case DELETION_VECTORS_INDEX:
+ compactDvIndexFiles.add(
+ new IndexManifestEntry(
+ FileKind.ADD,
+ commitMessage.partition(),
+ commitMessage.bucket(),
+ f));
+ break;
+ default:
+ throw new RuntimeException("Unknown index
type: " + f.indexType());
+ }
+ });
+
+ // todo: split them
Review Comment:
Let's finish todo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
