wwj6591812 commented on code in PR #6324:
URL: https://github.com/apache/paimon/pull/6324#discussion_r2418666147
##########
paimon-core/src/main/java/org/apache/paimon/table/source/AbstractDataTableScan.java:
##########
@@ -338,8 +340,18 @@ private StartingScanner
createIncrementalStartingScanner(SnapshotManager snapsho
Optional<Tag> endTag =
tagManager.get(incrementalBetween.getRight());
if (startTag.isPresent() && endTag.isPresent()) {
- return IncrementalDiffStartingScanner.betweenTags(
- startTag.get(), endTag.get(), snapshotManager,
incrementalBetween);
+ CoreOptions.IncrementalBetweenScanMode scanMode =
+ options.incrementalBetweenScanMode();
+ if (scanMode == CHANGELOG || scanMode == DELTA) {
+ return IncrementalDeltaStartingScanner.betweenSnapshotIds(
Review Comment:
The exception will be throw in
IncrementalDeltaStartingScanner#betweenSnapshotIds, In this case, we don't
support read delta / changelog between tags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
