JingsongLi commented on code in PR #6364:
URL: https://github.com/apache/paimon/pull/6364#discussion_r2415435078
##########
paimon-core/src/main/java/org/apache/paimon/table/sink/TableWrite.java:
##########
@@ -57,10 +59,12 @@ default TableWrite withMemoryPool(MemorySegmentPool
memoryPool) {
int getBucket(InternalRow row);
/** Write a row to the writer. */
- void write(InternalRow row) throws Exception;
+ @Nullable
+ SinkRecord write(InternalRow row) throws Exception;
Review Comment:
SinkRecord is not public API, should not return it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]