JingsongLi commented on code in PR #6407:
URL: https://github.com/apache/paimon/pull/6407#discussion_r2435838378
##########
paimon-core/src/main/java/org/apache/paimon/index/IndexFileHandler.java:
##########
@@ -52,20 +58,28 @@ public class IndexFileHandler {
private final IndexFilePathFactories pathFactories;
private final MemorySize dvTargetFileSize;
private final boolean dvBitmap64;
+ @Nullable private CacheMetrics cacheMetrics;
+ private final boolean enableDVMetaCache;
public IndexFileHandler(
FileIO fileIO,
SnapshotManager snapshotManager,
IndexManifestFile indexManifestFile,
IndexFilePathFactories pathFactories,
MemorySize dvTargetFileSize,
- boolean dvBitmap64) {
+ boolean dvBitmap64,
+ boolean enableDVMetaCache) {
Review Comment:
Why not just pass `DVMetaCache` here? You don't need use `IndexManifestFile`
for cache at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
