Zouxxyy commented on code in PR #6349:
URL: https://github.com/apache/paimon/pull/6349#discussion_r2386615666
##########
paimon-core/src/main/java/org/apache/paimon/compact/CompactDeletionFile.java:
##########
@@ -81,18 +89,20 @@ public CompactDeletionFile mergeOldFile(CompactDeletionFile
old) {
throw new IllegalStateException("old should not be get, this
is a bug.");
}
- if (deletionFile == null) {
+ if (newDeletionFile == null) {
return old;
}
old.clean();
+ // Keep the old deletion file.
Review Comment:
Here, we should keep the old deletion file
##########
paimon-core/src/main/java/org/apache/paimon/index/DynamicBucketIndexMaintainer.java:
##########
@@ -87,9 +89,11 @@ public List<IndexFileMeta> prepareCommit() {
throw new RuntimeException(e);
}
modified = false;
- return Collections.singletonList(entry);
+ IndexFileMeta toRemove = beforeFile;
Review Comment:
In the streaming scenario, the index maintainer will always hold it and not
create it repeatedly, so this logic needs to be added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
