JingsongLi commented on code in PR #6351:
URL: https://github.com/apache/paimon/pull/6351#discussion_r2389613384


##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/source/FileStoreSourceSplitReader.java:
##########
@@ -77,12 +78,13 @@ public class FileStoreSourceSplitReader
     public FileStoreSourceSplitReader(
             TableRead tableRead,
             @Nullable RecordLimiter limiter,
-            FileStoreSourceReaderMetrics metrics) {
+            FileStoreSourceReaderMetrics metrics,
+            @Nullable Integer blobField) {
         this.tableRead = tableRead;
         this.limiter = limiter;
         this.splits = new LinkedList<>();
         this.pool = new Pool<>(1);
-        this.pool.add(new FileStoreRecordIterator());
+        this.pool.add(new FileStoreRecordIterator(blobField));

Review Comment:
   Can you just pass readType here?



##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/FlinkConnectorOptions.java:
##########
@@ -539,6 +539,12 @@ public class FlinkConnectorOptions {
                                     + "multiple option group separated by 
commas. "
                                     + "Now only 'external-paths' is 
supported.");
 
+    public static final ConfigOption<String> BLOB_FIELD =

Review Comment:
   add this to `CoreOptions`? Spark will use this too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to