JingsongLi commented on code in PR #6472:
URL: https://github.com/apache/paimon/pull/6472#discussion_r2468878254
##########
paimon-core/src/main/java/org/apache/paimon/append/cluster/IncrementalClusterManager.java:
##########
@@ -118,11 +153,26 @@ public Map<BinaryRow, CompactUnit>
prepareForCluster(boolean fullCompaction) {
.collect(
Collectors.toMap(
Map.Entry::getKey,
- entry ->
-
incrementalClusterStrategy.pick(
- maxLevel,
- entry.getValue(),
- fullCompaction)));
+ entry -> {
+ if (fullCompaction) {
+ return
incrementalClusterStrategy.pick(
+ maxLevel,
entry.getValue(), true);
+ } else {
+ // if clustering is not in
full mode, then specified
+ // partitions should perform
incremental clustering
+ // and history partitions
should perform full
+ // clustering
+ if (specifiedPartitions != null
Review Comment:
Don't need to modify here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
