JingsongLi commented on code in PR #6483:
URL: https://github.com/apache/paimon/pull/6483#discussion_r2471646573
##########
paimon-core/src/main/java/org/apache/paimon/io/DataFileMeta.java:
##########
@@ -332,4 +333,19 @@ static long getMaxSequenceNumber(List<DataFileMeta>
fileMetas) {
.max(Long::compare)
.orElse(-1L);
}
+
+ static RoaringBitmap32 readIndices(List<Long> indices, DataFileMeta file) {
Review Comment:
add a non-static method to `DataFileMeta`: `RoaringBitmap32
toFileSelection(List<Long> indices)`.
Should throw exception if `firstRowId` is null.
##########
paimon-core/src/main/java/org/apache/paimon/table/source/ReadBuilder.java:
##########
@@ -149,6 +149,8 @@ default ReadBuilder withFilter(List<Predicate> predicates) {
*/
ReadBuilder withShard(int indexOfThisSubtask, int
numberOfParallelSubtasks);
+ ReadBuilder withRowIds(List<Long> indices);
Review Comment:
Add some comments.
##########
paimon-common/src/main/java/org/apache/paimon/reader/FileRecordIterator.java:
##########
@@ -107,4 +109,47 @@ public void releaseBatch() {
}
};
}
+
+ default FileRecordIterator<T> selection(RoaringBitmap32 selection) {
Review Comment:
Add a ut for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
