JingsongLi commented on code in PR #6489:
URL: https://github.com/apache/paimon/pull/6489#discussion_r2476205042
##########
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java:
##########
@@ -1120,8 +1123,16 @@ CommitResult tryCommitOnce(
}
// the added records subtract the deleted records from
- long deltaRecordCount = recordCountAdd(deltaFiles) -
recordCountDelete(deltaFiles);
- long totalRecordCount = previousTotalRecordCount +
deltaRecordCount;
+ long deltaRecordCount;
+ long totalRecordCount;
+
+ if (dataEvolutionEnabled) {
+ deltaRecordCount = nextRowIdStart - firstRowIdStart;
+ totalRecordCount = nextRowIdStart;
+ } else {
+ deltaRecordCount = recordCountAdd(deltaFiles) -
recordCountDelete(deltaFiles);
Review Comment:
I think we don't need to modify here, we should also modify split row count
just like python.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
