tsreaper commented on code in PR #6533:
URL: https://github.com/apache/paimon/pull/6533#discussion_r2496891428
##########
paimon-core/src/main/java/org/apache/paimon/mergetree/compact/MergeTreeCompactRewriter.java:
##########
@@ -104,7 +104,9 @@ protected CompactResult rewriteCompaction(
List<DataFileMeta> before = extractFilesFromSections(sections);
notifyRewriteCompactBefore(before);
- return new CompactResult(before, writer.result());
+ List<DataFileMeta> after = writer.result();
+ after = notifyRewriteCompactAfter(after);
+ return new CompactResult(before, after);
Review Comment:
1. For files in `before`, you also need to delete their lookup files. Add
tests on snapshot expire to check this.
2. No need to create another lookup file, if the original file is upgraded,
but not compacted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
