JingsongLi commented on code in PR #6556:
URL: https://github.com/apache/paimon/pull/6556#discussion_r2509127907
##########
paimon-core/src/main/java/org/apache/paimon/table/format/FormatTableScan.java:
##########
@@ -240,14 +242,58 @@ private List<Split> createSplits(FileIO fileIO, Path
path, BinaryRow partition)
FileStatus[] files = fileIO.listFiles(path, true);
for (FileStatus file : files) {
if (isDataFileName(file.getPath().getName())) {
- FormatDataSplit split =
- new FormatDataSplit(file.getPath(), 0, file.getLen(),
partition);
- splits.add(split);
+ if (isSplittableFile(table.format(),
file.getPath().getName())) {
Review Comment:
Merge this `isSplittableFile` into `splitLargeFile`. Rename `splitLargeFile
` to `tryToSplitLargeFile`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
