Zouxxyy commented on code in PR #6621:
URL: https://github.com/apache/paimon/pull/6621#discussion_r2534400042
##########
paimon-spark/paimon-spark-common/src/main/scala/org/apache/paimon/spark/PaimonBaseScan.scala:
##########
@@ -141,37 +160,14 @@ abstract class PaimonBaseScan(
""
}
- val latestSnapshotId = if (table.latestSnapshot().isPresent) {
- Some(table.latestSnapshot().get.id)
- } else {
- None
- }
-
- val latestSnapshotIdStr = if (latestSnapshotId.isDefined) {
- s", LatestSnapshotId: [${latestSnapshotId.get}]"
+ val latestSnapshotIdStr = if (latestSnapshot.nonEmpty) {
Review Comment:
It's not very useful, it will increase request, I'm inclined to remove it.
##########
paimon-spark/paimon-spark-common/src/main/scala/org/apache/paimon/spark/PaimonBaseScan.scala:
##########
@@ -141,37 +160,14 @@ abstract class PaimonBaseScan(
""
}
- val latestSnapshotId = if (table.latestSnapshot().isPresent) {
- Some(table.latestSnapshot().get.id)
- } else {
- None
- }
-
- val latestSnapshotIdStr = if (latestSnapshotId.isDefined) {
- s", LatestSnapshotId: [${latestSnapshotId.get}]"
+ val latestSnapshotIdStr = if (latestSnapshot.nonEmpty) {
Review Comment:
It's not very useful and will increase request, I'm inclined to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
