yunfengzhou-hub commented on code in PR #6606: URL: https://github.com/apache/paimon/pull/6606#discussion_r2558985361
########## paimon-flink/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/pipeline/cdc/CDCOptions.java: ########## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.paimon.flink.pipeline.cdc; + +import org.apache.paimon.options.ConfigOption; +import org.apache.paimon.options.ConfigOptions; +import org.apache.paimon.options.FallbackKey; + +import org.apache.flink.util.IterableUtils; + +import java.time.Duration; + +/** Options for the cdc source. */ +public class CDCOptions { + /** prefix for passing properties for catalog creation. */ + public static final String PREFIX_CATALOG_PROPERTIES = "catalog.properties."; Review Comment: `scan.mode` should have been supported, as `AbstractDataTableScan#createStartingScanner` has been using this parameter. For `consumer-id` and other potential parameters, I prefer to have them checked and supported in separated PRs in future. This is because this PR has been big enough for reviewers, and such parameters are extensive functionalities built upon the basic read/write correctness, and thus can be separated into future PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
