XiaoHongbo-Hope commented on code in PR #6668:
URL: https://github.com/apache/paimon/pull/6668#discussion_r2564073709
##########
paimon-python/pypaimon/write/file_store_write.py:
##########
@@ -30,23 +32,27 @@
class FileStoreWrite:
"""Base class for file store write operations."""
- def __init__(self, table):
+ def __init__(self, table, commit_user):
from pypaimon.table.file_store_table import FileStoreTable
self.table: FileStoreTable = table
self.data_writers: Dict[Tuple, DataWriter] = {}
self.max_seq_numbers: dict = {}
self.write_cols = None
self.commit_identifier = 0
+ self.options = dict(table.options)
+ self.options[CoreOptions.DATA_FILE_PREFIX] = \
+ (f"{table.options.get(CoreOptions.DATA_FILE_PREFIX,
'data-')}-u-{commit_user}"
+ f"-s-{random.randint(0, 2 ** 31 - 2)}-w-")
Review Comment:
does this default value processing will cover all the case? suggest to add
method in core_options to handle the default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
