XiaoHongbo-Hope commented on code in PR #6686:
URL: https://github.com/apache/paimon/pull/6686#discussion_r2580804276
##########
paimon-python/pypaimon/read/table_read.py:
##########
@@ -126,10 +126,24 @@ def to_duckdb(self, splits: List[Split], table_name: str,
con.register(table_name, self.to_arrow(splits))
return con
- def to_ray(self, splits: List[Split]) -> "ray.data.dataset.Dataset":
+ def to_ray(self, splits: List[Split], use_distributed_read: bool = True)
-> "ray.data.dataset.Dataset":
Review Comment:
> Suggestion: Replace `use_distributed_read: bool` with `parallelism: int =1
`. This way, parallelism=1 indicates a single-task read, and other values can
be passed directly to `ray.data.read_datasource(datasource, parallelism)`.
`parallelism` is more useful, instead of just serving as a binary switch.
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
